fix: feat: fix for new transformers (>4.48) and new QLinear for INT8 training with HW emulation#141
Merged
chichun-charlie-liu merged 7 commits intoJun 24, 2025
Conversation
Signed-off-by: cliu-us <cliu@us.ibm.com>
…king HW simulation into account Signed-off-by: cliu-us <cliu@us.ibm.com>
…y increase in rel errs, change settings in tests to match what we had before Signed-off-by: cliu-us <cliu@us.ibm.com>
Collaborator
Can we update the unit tests to reflect this new default value for the triton kernels, instead of adding this flag? |
Signed-off-by: cliu-us <cliu@us.ibm.com>
Signed-off-by: cliu-us <cliu@us.ibm.com>
…t being fp32 Signed-off-by: cliu-us <cliu@us.ibm.com>
6 tasks
BrandonGroth
approved these changes
Jun 24, 2025
BrandonGroth
approved these changes
Jun 24, 2025
988add0
into
foundation-model-stack:main
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Evaluator.evaluate()accordingly to accommodate both old and new versions.QLinearINT8Trainfor INT8 training with HW emulation taken into account.<this flag>=Falsein unit tests and keep itTruefor real use.Related issues or PRs
Will close #122 and #127 after this PR is merged.
How to verify the PR
dqexample was tested with new version of transformers (4.52), which will show correct perplexity instead of throwing errors.Was the PR tested
Checklist for passing CI/CD:
git commit -signoffor equivalenttox -e fixtox -e linttox -e spellchecktox -e unitNote: CI/CD performs unit tests on multiple versions of Python from a fresh install. There may be differences with your local environment and the test environment.